Improvements

utxo/src/amount.rs

@@ -47,13 +47,13 @@ impl Serialize for Amount {
 
 impl Amount {
     /// Creates a new amount from an asset and cents
-    pub fn new(asset: Asset, cents: AmountCents) -> Self {
+    pub(crate) fn new(asset: Asset, cents: AmountCents) -> Self {
         Self { asset, cents }
     }
 
     /// Creates a new amount from a human amount (a floating number serialized
     /// as string to avoid loss precision)
-    pub fn from_human(asset: Asset, human_amount: &str) -> Result<Self, Error> {
+    pub(crate) fn from_human(asset: Asset, human_amount: &str) -> Result<Self, Error> {
         let mut dot_at = None;
         for (pos, i) in human_amount.chars().enumerate() {
             match i {
@@ -134,8 +134,8 @@ impl ToString for Amount {
             left,
             right
         )
-        .trim_end_matches("0")
-        .trim_end_matches(".")
+        .trim_end_matches('0')
+        .trim_end_matches('.')
         .to_owned()
     }
 }

utxo/src/error.rs

@@ -1,6 +1,5 @@
 use crate::{amount, asset::AssetId, storage, transaction, AccountId};
 use serde::Serialize;
-use std::fmt::Display;
 
 /// The errors that can happen in the Verax crate
 #[derive(thiserror::Error, Debug, Serialize)]

utxo/src/id.rs

@@ -179,11 +179,11 @@ impl FromStr for AnyId {
         if value.starts_with("account") {
             Ok(Self::Account(value.parse()?))
         } else if value.starts_with("tx") {
-            if let Some(at) = value.find(":") {
+            if let Some(at) = value.find(':') {
                 let (tx, pos) = value.split_at(at);
                 Ok(Self::Payment(PaymentId {
                     transaction: tx.parse()?,
-                    position: (&pos[1..]).parse()?,
+                    position: (pos[1..]).parse()?,
                 }))
             } else {
                 Ok(Self::Transaction(value.parse()?))

utxo/src/ledger.rs

@@ -33,7 +33,7 @@ where
 
     /// Parses a human amount (float amounts serialized as string to avoid precision loss)
     pub fn parse_amount(&self, asset: &str, amount: &str) -> Result<Amount, Error> {
-        Ok(self.asset_manager.human_amount_by_name(asset, amount)?)
+        self.asset_manager.human_amount_by_name(asset, amount)
     }
 
     /// Returns a reference to the asset manager

utxo/src/lib.rs

@@ -18,7 +18,7 @@
 //! auditable friendly.
 
 #![deny(missing_docs)]
-#![allow(warnings)]
+#![deny(warnings)]
 
 mod amount;
 mod asset;

utxo/src/payment.rs

@@ -1,4 +1,4 @@
-use crate::{changelog::Changelog, AccountId, Amount, Error, Status, TransactionId};
+use crate::{changelog::Changelog, AccountId, Amount, Status, TransactionId};
 use serde::{Deserialize, Serialize, Serializer};
 use std::ops::Deref;
 

utxo/src/serde.rs

@@ -1,4 +1,4 @@
-use serde::{Serialize, Serializer};
+use serde::Serializer;
 use std::{fmt::Display, sync::Arc};
 
 pub(crate) fn serialize_error_to_string<S, T>(value: &T, serializer: S) -> Result<S::Ok, S::Error>

utxo/src/transaction/inner.rs

@@ -37,7 +37,7 @@ use std::{collections::HashMap, ops::Deref};
 /// either as settled, cancelled or failed. A higher layer should split any
 /// available payment to be spend into a new transaction, and then finalize the
 /// transaction, and reserve only the exact amount to be spent, otherwise
-/// unrelated funds will be held unspentable until the transaction is finalized.
+/// unrelated funds will be held unspendable until the transaction is finalized.
 #[derive(Debug, Clone, Serialize)]
 pub struct Transaction {
     id: TransactionId,
@@ -252,7 +252,7 @@ impl Transaction {
         )];
 
         Ok(Self {
-            id: id,
+            id,
             reference,
             spends: spend,
             typ,
@@ -283,8 +283,8 @@ impl Transaction {
             hasher.update(&bincode::serialize(account)?);
             hasher.update(&bincode::serialize(amount)?);
         }
-        hasher.update(&created_at.timestamp_millis().to_le_bytes());
-        hasher.update(&reference);
+        hasher.update(created_at.timestamp_millis().to_le_bytes());
+        hasher.update(reference);
         Ok(TransactionId::new(hasher.finalize().into()))
     }
 
@@ -500,7 +500,7 @@ impl Transaction {
         for payment in self.creates.iter() {
             batch.store_new_payment(payment).await?;
             batch
-                .relate_account_to_transaction(&self, &payment.to)
+                .relate_account_to_transaction(self, &payment.to)
                 .await?;
             batch.store_changelogs(&payment.changelog).await?;
         }
@@ -508,13 +508,11 @@ impl Transaction {
             batch
                 .update_payment(&input.id, &self.id, self.status.clone())
                 .await?;
-            batch
-                .relate_account_to_transaction(&self, &input.to)
-                .await?;
+            batch.relate_account_to_transaction(self, &input.to).await?;
             batch.store_changelogs(&input.changelog).await?;
         }
 
-        batch.tag_transaction(&self, &self.tags).await?;
+        batch.tag_transaction(self, &self.tags).await?;
         batch.store_changelogs(&self.changelog).await?;
         batch.commit().await?;
         Ok(())