Quellcode durchsuchen

Apply suggestions from code review

Co-authored-by: ok300 <106775972+ok300@users.noreply.github.com>
Co-authored-by: thesimplekid <tsk@thesimplekid.com>
Cesar Rodas vor 1 Monat
Ursprung
Commit
db251fa837

+ 2 - 0
crates/cdk-signatory/build.rs

@@ -1,4 +1,6 @@
 fn main() {
+    println!("cargo:rerun-if-changed=src/proto/signatory.proto");
+
     #[cfg(feature = "grpc")]
     tonic_build::compile_protos("proto/signatory.proto").unwrap();
 }

+ 1 - 0
crates/cdk-signatory/src/embedded.rs

@@ -55,6 +55,7 @@ impl Service {
         }
     }
 
+    #[tracing::instrument(skip_all)]
     async fn runner(
         mut receiver: mpsc::Receiver<Request>,
         handler: Arc<dyn Signatory + Send + Sync>,

+ 1 - 1
crates/cdk-signatory/src/proto/client.rs

@@ -39,7 +39,7 @@ impl SignatoryRpcClient {
     pub async fn new<A: AsRef<Path>>(url: String, tls_dir: Option<A>) -> Result<Self, ClientError> {
         let channel = if let Some(tls_dir) = tls_dir {
             let tls_dir = tls_dir.as_ref();
-            let server_root_ca_cert = std::fs::read_to_string(tls_dir.join("ca.pem")).unwrap();
+            let server_root_ca_cert = std::fs::read_to_string(tls_dir.join("ca.pem"))?;
             let server_root_ca_cert = Certificate::from_pem(server_root_ca_cert);
             let client_cert = std::fs::read_to_string(tls_dir.join("client.pem"))?;
             let client_key = std::fs::read_to_string(tls_dir.join("client.key"))?;

+ 0 - 1
crates/cdk-signatory/src/proto/server.rs

@@ -47,7 +47,6 @@ where
             Err(err) => proto::blind_sign_response::Result::Error(err.into()),
         };
 
-        //.map_err(|e| Status::from_error(Box::new(e)))?;
         Ok(Response::new(proto::BlindSignResponse {
             result: Some(result),
         }))