Apply suggestions from code review

Co-authored-by: thesimplekid <tsk@thesimplekid.com>

crates/cdk-axum/src/ws/mod.rs

@@ -84,9 +84,10 @@ pub async fn main_websocket(mut socket: WebSocket, state: MintState) {
                     continue;
                 };
 
-                if socket.send(Message::Text(message)).await.is_err() {
-                    break;
-                }
+          if let Err(err)= socket.send(Message::Text(message)).await {
+                   tracing::error!("Could not send websocket message: {}", err);
+                     break;
+          }
             }
             Some(Ok(Message::Text(text))) = socket.next() => {
                 let request = match serde_json::from_str::<WsRequest>(&text) {

crates/cdk-axum/src/ws/subscribe.rs

@@ -13,6 +13,7 @@ pub struct Method(Params);
 #[derive(Debug, Clone, serde::Serialize)]
 pub struct Response {
     status: String,
+    #[serde(rename = "subId")]  
     sub_id: SubId,
 }
 

crates/cdk-axum/src/ws/unsubscribe.rs

@@ -3,6 +3,7 @@ use cdk::pub_sub::SubId;
 
 #[derive(Debug, Clone, serde::Serialize, serde::Deserialize)]
 pub struct Method {
+    #[serde(rename = "subId")]
     pub sub_id: SubId,
 }
 

crates/cdk-integration-tests/tests/regtest.rs

@@ -101,7 +101,7 @@ async fn test_regtest_mint_melt_round_trip() -> Result<()> {
 
     assert_eq!(
         reader.next().await.unwrap().unwrap().to_text().unwrap(),
-        r#"{"jsonrpc":"2.0","result":{"status":"OK","sub_id":"test-sub"},"id":2}"#
+        r#"{"jsonrpc":"2.0","result":{"status":"OK","subId":"test-sub"},"id":2}"#
     );
 
     let melt_response = wallet.melt(&melt.id).await.unwrap();

crates/cdk/src/pub_sub/mod.rs

@@ -158,8 +158,8 @@ where
 
     /// Task to remove dropped subscriptions from the storage struct
     ///
-    /// This task will run in the background (and will dropped when the Manager
-    /// is ) and will remove subscriptions from the storage struct it is dropped.
+    /// This task will run in the background (and will be dropped when the [`Manager`]
+    /// is) and will remove subscriptions from the storage struct it is dropped.
     async fn remove_subscription(
         mut receiver: mpsc::Receiver<(SubId, Vec<Index<I>>)>,
         storage: IndexTree<T, I>,